forked from ansible/awx
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] devel from ansible:devel #572
Open
pull
wants to merge
1,435
commits into
philipsd6:devel
Choose a base branch
from
ansible:devel
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+37,534
−356,330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:api
component:ui
community
component:awx_collection
labels
Feb 15, 2023
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Apr 18, 2023
of the Role relationships.
Apparently this has happened to a customer, per Nate Becker.
Doing the entire graph is too much on any system with real amounts of Roles.
…there This is actually happening for one customer, though it seems like it shouldn't be if the foreign key constraint is set back up properly. In order to recreate it, I had to add the constraint back with 'NOT VALID' added on to prevent the check.
Checking if parents and implicit_parents are consistent with ancestors.
This version, however, has false positives because Roles become children of Team.member_role when a Role is granted to a Team.
The results in my test now look correct.
…ssible since the foreign keys to the roles from the resources can make us go wrong almost immediately.
I think that rebuild_role_ancestor_list() will then correctly update all of the affected Role.ancestors.
it wound up being unworkable, and I think ultimately we only need to check the immediate parentage of each role.
Also, make use of up-front defined arrays of the tables involved, for ease of editing in the future.
By stable, we mean future occurrences of the rrule should be the same before and after the fast forward operation. The problem before was that we were fast forwarding to 7 days ago. For some rrules, this does not retain the old occurrences. Thus, jobs would launch at unexpected times. This change makes sure we fast forward in increments of the rrule INTERVAL, thus the new dtstart should be in the occurrence list of the old rrule. Additionally, code is updated to fast forward EXRULE (exclusion rules) in addition to RRULE --------- Signed-off-by: Seth Foster <[email protected]> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
* Revive the logstash container for testing * yamllint
* Replaced with larger graphic. * Revert "Replaced with larger graphic." This reverts commit 1214b00. * Removed UI-focused user docs from AWX. * Fixed indentation for release notes * Removed/updated image files no longer needed.
* Add descriptions for plugin names * Update serializers to display plugin and plugin description * Add function to extract plugin name descriptions * Add description for scm * Conditionalize scm and file descriptions
In essence, this configures Python to turn any warnings emitted in runtime into errors[[1]]. This is the best practice that allows reacting to future deprecation announcements that are coming from the dependencies (direct, or transitive, or even CPython itself)[[2]]. The typical workflow looks like this: 1. If a dependency is updated an a warning is hit in tests, the deprecated thing should be replaced with newer APIs. 2. If a dependency is transitive or we have no control over it otherwise, the specific warning and a regex matching its message, plus the module reference (where possible) can be added to the list of temporary ignores in `pytest.ini`. 3. The list of temporary ignores should be reevaluated periodically, including when dependency re-pinning in lockfile is happening. [1]: https://docs.python.org/3/using/cmdline.html#cmdoption-W [2]: https://pytest-with-eric.com/configuration/pytest-ignore-warnings/
* Remove oauth provider This removes the oauth provider functionality from awx. The oauth2_provider app and all references to it have been removed. Migrations to delete the two tables that locally overwrote oauth2_provider tables are included. This change does not include migrations to delete the tables provided by the oauth2_provider app. Also not included here are changes to awxkit, awx_collection or the ui. * Fix linters * Update migrations after rebase * Update collection tests for auth changes The changes in #15554 will cause a few collection tests to fail, depending on what the test configuration is. This changes the tests to look for a specific warning rather than counting the number of warnings emitted. * Update migration * Removed unused oauth_scopes references --------- Co-authored-by: Mike Graves <[email protected]> Co-authored-by: Alan Rominger <[email protected]>
* add custom 404 page * cowsay 404
* Preparation for moving inject_credentials out of this repo
* add sphinx notfound extension * add notfound conf * upgrade requirements * use double backticks * add urls prefix
* use subproject url prefix * add version details
* feat: enable django flags support * add django flags license * re-run updater script
Fix bug introduced by #15392 that cause workunit to NOT be auto released after job completes
Update defaults.py fixing typo for RECEPTOR_KEEP_WORK_ON_ERROR
…es (#15688) * PoC for running dev env tests * Replace in github actions * Try non interactive * Move folder to better location * Further streamlining of new test folders * Consolidate fixture, add writeup docs * Use star import * Push the wait-for-job to the conftest
Fix error creating partition due to uncaught exception the primary fix is to simply add an exception class to those caught in the except block This also adds live tests for the general scenario although this does not hit the new exception type
* Unit tests do not create CredentialType records for Credential plugins. Instead, they explicitly instantiate CredentialType(s) for Credential plugins. They rely on CredentialType.defaults[key] to do so. This change makes sure custom_injectors get bolted onto the created CredentialType.
Fix project cache identifiers for new updates Finish test and discover viable solution Add comment on related task code
Signed-off-by: Seth Foster <[email protected]>
* Use runtime log utility moved to DAB
Fixes a bug where a schedule that was created to run only once will continue to run repeatedly. e.g. an rrule with dtstart 20240730; count 1; freq MINUTELY This job will run on 20240730, and should never run again. However, the next time the schedule update_computed_fields runs, the dtstart will fast forward to today's date, and next_run will be computed from that. This will trigger the job to run again, which is not intended. If count is set, we just should not fast forward the rrule and always calculate next_run based on original dtstart. Signed-off-by: Seth Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⤵️ pull
community
component:api
component:awx_collection
component:cli
component:docs
component:ui
dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )